Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: net/url_request/url_request_job.h

Issue 1080763003: Remove URLRequestJob::filter_input_byte_count_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix merge Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job.h
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index a105d79907532487a15eddabe04be24ab253237b..b6ae4bbeb13af7129c5d875c019962cf94b672de 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -339,17 +339,14 @@ class NET_EXPORT URLRequestJob
// Set the proxy server that was used, if any.
void SetProxyServer(const HostPortPair& proxy_server);
- // The number of bytes read before passing to the filter.
+ // The number of bytes read before passing to the filter. This value reflects
+ // bytes read even when there is no filter.
int64 prefilter_bytes_read() const { return prefilter_bytes_read_; }
- // The number of bytes read after passing through the filter.
+ // The number of bytes read after passing through the filter. This value
+ // reflects bytes read even when there is no filter.
int64 postfilter_bytes_read() const { return postfilter_bytes_read_; }
- // Total number of bytes read from network (or cache) and typically handed
- // to filter to process. Used to histogram compression ratios, and error
- // recovery scenarios in filters.
- int64 filter_input_byte_count() const { return filter_input_byte_count_; }
-
// The request that initiated this job. This value MAY BE NULL if the
// request was released by DetachRequest().
URLRequest* request_;
@@ -384,7 +381,8 @@ class NET_EXPORT URLRequestJob
bool FilterHasData();
// Subclasses may implement this method to record packet arrival times.
- // The default implementation does nothing.
+ // The default implementation does nothing. Only invoked when bytes have been
+ // read since the last invocation.
virtual void UpdatePacketReadTimes();
// Computes a new RedirectInfo based on receiving a redirect response of
@@ -398,7 +396,6 @@ class NET_EXPORT URLRequestJob
int64 prefilter_bytes_read_;
int64 postfilter_bytes_read_;
- int64 filter_input_byte_count_;
// The data stream filter which is enabled on demand.
scoped_ptr<Filter> filter_;
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698