Remove URLRequestJob::filter_input_byte_count_

net/url_request/url_request_http_job.cc

Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 1a60ac4f52cb6e13fbc7bde9810114eba65787aa..803886eb8c48d1a1378121459b91c273e52ca513 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -114,7 +114,7 @@ URLRequestHttpJob::HttpFilterContext::SdchDictionariesAdvertised() const {
 }
 
 int64 URLRequestHttpJob::HttpFilterContext::GetByteReadCount() const {
-  return job_->filter_input_byte_count();
+  return job_->prefilter_bytes_read();
 }
 
 int URLRequestHttpJob::HttpFilterContext::GetResponseCode() const {
@@ -1392,17 +1392,14 @@ void URLRequestHttpJob::UpdatePacketReadTimes() {
   if (!packet_timing_enabled_)
     return;
 
-  if (filter_input_byte_count() <= bytes_observed_in_packets_) {
-    DCHECK_EQ(filter_input_byte_count(), bytes_observed_in_packets_);
-    return;  // No new bytes have arrived.
-  }
+  DCHECK_GT(prefilter_bytes_read(), bytes_observed_in_packets_);

[mmenke, 2015/04/10 21:48:02]

We never call UpdatePacketReadTimes() when we didn't actually read any data, so
the condition of this if was always false.

[Randy Smith (Not in Mondays), 2015/04/10 22:03:57]

Yeah, but it's part of the URLRequestJob -> subclass interface.   This doesn't
break anything *now*, but ... :-}.  Could you update the comment in
url_request_job.h to indicate that this function will only be called when bytes
have been read since the last call to it?

[mmenke, 2015/04/10 22:36:49]

Done.

 
   base::Time now(base::Time::Now());
   if (!bytes_observed_in_packets_)
     request_time_snapshot_ = now;
   final_packet_time_ = now;
 
-  bytes_observed_in_packets_ = filter_input_byte_count();
+  bytes_observed_in_packets_ = prefilter_bytes_read();
 }
 
 void URLRequestHttpJob::RecordPacketStats(