Remove URLRequestJob::filter_input_byte_count_

Remove URLRequestJob::filter_input_byte_count_

It's now identical to prefilter_bytes_read_.  They've been basically
identical since they were added, 4 years ago.

BUG=none

Committed: https://crrev.com/bbf19be21867e4631295c2247abfd3acd88e05ea
Cr-Commit-Position: refs/heads/master@{#324759}

[mmenke, 2015-04-10 21:46:50]

mmenke@chromium.org changed reviewers:
+ rdsmith@chromium.org

[mmenke, 2015-04-10 21:46:51]

Randy:  Sending this to you since this was added for and is only used by SDCH,
and you still own the histograms that use it (Should you pass them to Elly now? 
Maybe I should have sent this to her?)

Note that filter_input_byte_count_ is an int64, while prefilter_bytes_read_ is
an int, but this is a bug, which  https://codereview.chromium.org/1074293003/
fixes.  I'll hold off on landing this CL until after that one lands.

[mmenke, 2015-04-10 21:48:02]

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job.cc:1395: DCHECK_GT(prefilter_bytes_read(),
bytes_observed_in_packets_);
We never call UpdatePacketReadTimes() when we didn't actually read any data, so
the condition of this if was always false.

[Randy Smith (Not in Mondays), 2015-04-10 22:03:58]

I'm inclined to think that if it's in the filter infrastructure it's reasonable
to send me the CLs, even if it was only put into the infrastructure for SDCH. 
It's hardly alone in that honor.  I'll throw together a CL to give Elly
ownership of the sdch histograms.

LGTM with comments below.

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job.cc:1395: DCHECK_GT(prefilter_bytes_read(),
bytes_observed_in_packets_);
On 2015/04/10 21:48:02, mmenke wrote:
> We never call UpdatePacketReadTimes() when we didn't actually read any data,
so
> the condition of this if was always false.

Yeah, but it's part of the URLRequestJob -> subclass interface.   This doesn't
break anything *now*, but ... :-}.  Could you update the comment in
url_request_job.h to indicate that this function will only be called when bytes
have been read since the last call to it?

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
File net/url_request/url_request_job.h (right):

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
net/url_request/url_request_job.h:343: // when there is no filter.
nit: This doesn't feel like a complete sentence to me?  Maybe "This value
reflects bytes read even when there is no filter."?

[mmenke, 2015-04-10 22:36:49]

Thanks!

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job.cc:1395: DCHECK_GT(prefilter_bytes_read(),
bytes_observed_in_packets_);
On 2015/04/10 22:03:57, rdsmith wrote:
> On 2015/04/10 21:48:02, mmenke wrote:
> > We never call UpdatePacketReadTimes() when we didn't actually read any data,
> so
> > the condition of this if was always false.
> 
> Yeah, but it's part of the URLRequestJob -> subclass interface.   This doesn't
> break anything *now*, but ... :-}.  Could you update the comment in
> url_request_job.h to indicate that this function will only be called when
bytes
> have been read since the last call to it?

Done.

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
File net/url_request/url_request_job.h (right):

https://codereview.chromium.org/1080763003/diff/1/net/url_request/url_request...
net/url_request/url_request_job.h:343: // when there is no filter.
On 2015/04/10 22:03:58, rdsmith wrote:
> nit: This doesn't feel like a complete sentence to me?  Maybe "This value
> reflects bytes read even when there is no filter."?

Done.

[mmenke, 2015-04-11 01:22:02]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2015-04-11 01:22:03]

The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/1080763003/#ps60001
(title: "Fix merge")

[commit-bot: I haz the power, 2015-04-11 01:24:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1080763003/60001

[commit-bot: I haz the power, 2015-04-11 02:45:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-11 02:46:11]

Patchset 4 (id:??) landed as
https://crrev.com/bbf19be21867e4631295c2247abfd3acd88e05ea
Cr-Commit-Position: refs/heads/master@{#324759}