Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 108073002: Error handling and refactoring in tools/linux/procfs.py, and rename multi-process-rss.py. (Closed)

Created:
7 years ago by Dai Mikurube (NOT FULLTIME)
Modified:
6 years, 12 months ago
Reviewers:
peria
CC:
chromium-reviews
Visibility:
Public.

Description

Error handling and refactoring in tools/linux/procfs.py, and rename multi-process-rss.py. BUG=324194 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242476

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -154 lines) Patch
M tools/linux/procfs.py View 1 7 chunks +33 lines, -12 lines 0 comments Download
D tools/multi-process-rss.py View 1 chunk +0 lines, -143 lines 0 comments Download
A + tools/multi_process_rss.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dai Mikurube (NOT FULLTIME)
Could you take a look when you have time? It's separated from https://codereview.chromium.org/106973006/ since I ...
7 years ago (2013-12-06 10:07:26 UTC) #1
peria
LGTM with a nit. https://codereview.chromium.org/108073002/diff/1/tools/linux/procfs.py File tools/linux/procfs.py (right): https://codereview.chromium.org/108073002/diff/1/tools/linux/procfs.py#newcode143 tools/linux/procfs.py:143: except (IOError, OSError): You use ...
7 years ago (2013-12-09 05:08:13 UTC) #2
Dai Mikurube (NOT FULLTIME)
Thanks!
6 years, 12 months ago (2013-12-25 04:28:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/108073002/20001
6 years, 12 months ago (2013-12-25 04:28:37 UTC) #4
commit-bot: I haz the power
6 years, 12 months ago (2013-12-25 04:28:49 UTC) #5
Message was sent while issue was closed.
Change committed as 242476

Powered by Google App Engine
This is Rietveld 408576698