Implementation of Smart GO NEXT feature in Android Chrome

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 9e0c4207e80039bff552964d85310cd9972ffedf..b547b1988bf3a0560456e8b6a1aa40a5ed5d3fd1 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -113,6 +113,7 @@
 #include "third_party/WebKit/public/platform/WebCString.h"
 #include "third_party/WebKit/public/platform/WebConnectionType.h"
 #include "third_party/WebKit/public/platform/WebDragData.h"
+#include "third_party/WebKit/public/platform/WebFocusType.h"
 #include "third_party/WebKit/public/platform/WebHTTPBody.h"
 #include "third_party/WebKit/public/platform/WebImage.h"
 #include "third_party/WebKit/public/platform/WebMessagePortChannel.h"
@@ -1284,6 +1285,8 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
                         OnScrollFocusedEditableNodeIntoRect)
     IPC_MESSAGE_HANDLER(InputMsg_SetEditCommandsForNextKeyEvent,
                         OnSetEditCommandsForNextKeyEvent)
+    IPC_MESSAGE_HANDLER(InputMsg_AdvanceFocusToNextFormControl,
+                        OnAdvanceFocusToNextFormControl)
     IPC_MESSAGE_HANDLER(ViewMsg_CopyImageAt, OnCopyImageAt)
     IPC_MESSAGE_HANDLER(ViewMsg_SaveImageAt, OnSaveImageAt)
     IPC_MESSAGE_HANDLER(ViewMsg_Find, OnFind)
@@ -1445,6 +1448,16 @@ void RenderViewImpl::OnSetHistoryOffsetAndLength(int history_offset,
   history_list_length_ = history_length;
 }
 
+void RenderViewImpl::OnAdvanceFocusToNextFormControl(bool forward) {
+  if (!webview())
+    return;
+
+  blink::WebFocusType focusType = blink::WebFocusTypeForward;
+  if (forward == false)
+    focusType = blink::WebFocusTypeBackward;

[Avi (use Gerrit), 2015/04/17 16:26:38]

Two comments before discarding this entire block.

First, if (forward == false) is crazy; do if (!forward).
Second, use_underscores_in_chromium_code, notCamelCase.

But do instead:

blink::WebFocusType focus_type = forward ? blink::WebFocusTypeForward :
blink::WebFocusTypeBackward;

[AKV, 2015/04/17 16:40:37]

Done. Thanks

+  webview()->advanceFocusToNextFormControl(focusType);
+}
+
 void RenderViewImpl::OnSetInitialFocus(bool reverse) {
   if (!webview())
     return;