Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1080633006: Deprecate 3-args ResourceConstraints::ConfigureDefaults (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate 3-args ResourceConstraints::ConfigureDefaults Embedders should use the 2-args version. Number of cores is just ignored. BUG=none R=dcarney@chromium.org LOG=y Committed: https://crrev.com/36f17ed0305017547fce39cb6a53c1c2ba79b3d8 Cr-Commit-Position: refs/heads/master@{#27938}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M include/v8.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-20 07:55:18 UTC) #1
dcarney
lgtm
5 years, 8 months ago (2015-04-20 07:57:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080633006/20001
5 years, 8 months ago (2015-04-20 09:22:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/5042)
5 years, 8 months ago (2015-04-20 09:25:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080633006/40001
5 years, 8 months ago (2015-04-20 11:20:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5021)
5 years, 8 months ago (2015-04-20 12:08:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080633006/40001
5 years, 8 months ago (2015-04-20 12:35:25 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-20 13:26:45 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 13:26:51 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/36f17ed0305017547fce39cb6a53c1c2ba79b3d8
Cr-Commit-Position: refs/heads/master@{#27938}

Powered by Google App Engine
This is Rietveld 408576698