Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 108063006: Add a UseCounter for Element.webkitMatchesSelector (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Add a UseCounter for Element.webkitMatchesSelector http://dom.spec.whatwg.org/#dom-element-matches Element.matches(selector) is now in DOM Standard, so the prefixed API should be removed as soon as reality allows. BUG=326652 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163375

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/dom/Element.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
7 years ago (2013-12-06 22:56:22 UTC) #1
eseidel
lgtm
7 years ago (2013-12-07 00:41:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/108063006/1
7 years ago (2013-12-07 00:43:41 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Element.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-07 00:43:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/108063006/20001
7 years ago (2013-12-07 19:55:43 UTC) #5
commit-bot: I haz the power
Change committed as 163375
7 years ago (2013-12-07 21:19:14 UTC) #6
arv (Not doing code reviews)
7 years ago (2013-12-09 14:49:07 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698