Give up focus if the focused view becomes unfocusable

ui/views/focus/focus_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/focus/focus_manager.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/auto_reset.h"
@@ skipping 335 matching lines @@
 
 void FocusManager::ClearFocus() {
   // SetFocusedView(NULL) is going to clear out the stored view to. We need to
   // persist it in this case.
   views::View* focused_view = GetStoredFocusView();
   SetFocusedView(NULL);
   ClearNativeFocus();
   SetStoredFocusView(focused_view);
 }
 
+void FocusManager::ClearFocusIfUnfocusable() {

[sky, 2013/12/11 21:29:29]

Why is this clearing and not advancing? Also, I think this implementation has to
be more careful. If the Widget the FocusManager is associated with is not active
I believe this will attempt to activate it.

[mohsen, 2013/12/12 18:26:54]

1. About clearing vs advancing, as I stated in my previous message:

"I still clear the focus instead of moving it to another view, as it seems more
natural to me. For example, if the user is typing in a textfield and, for
whatever reason, the textfield gets disabled, I think it is better to clear the
focus instead of moving the focus to another view, because the user may not
notice the change and continue typing and possibly override the other view's
data! But, if you think it is better to move focus to another view, it can be
done easily."

That's my only reason to prefer clearing, and I don't have a strong opinion
about it.

2. In the second sentence of your comment, do you mean that if the widget is not
active, clearing the focus might activate it? If this is the case then we will
have the problem anyway. Or I'm completely missing your point here?

+  if (focused_view_ && !focused_view_->IsAccessibilityFocusable())
+    ClearFocus();
+}
+
 void FocusManager::StoreFocusedView(bool clear_native_focus) {
   View* focused_view = focused_view_;
   // Don't do anything if no focused view. Storing the view (which is NULL), in
   // this case, would clobber the view that was previously saved.
   if (!focused_view_)
     return;
 
   View* v = focused_view_;
 
   if (clear_native_focus) {
@@ skipping 175 matching lines @@
   }
   if (key_code == ui::VKEY_RIGHT || key_code == ui::VKEY_DOWN) {
     AdvanceFocus(false);
     return true;
   }
 
   return false;
 }
 
 }  // namespace views