Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1080593007: bluetooth: Stub out BluetoothAdapterAndroid (Closed)

Created:
5 years, 8 months ago by scheib
Modified:
5 years, 7 months ago
Reviewers:
armansito
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Stub out BluetoothAdapterAndroid BUG=471536 Committed: https://crrev.com/35fbdd40277f2d4806abe3c90705f35d1e66bd8c Cr-Commit-Position: refs/heads/master@{#327562}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -67 lines) Patch
M device/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + device/bluetooth/bluetooth_adapter_android.h View 1 3 chunks +16 lines, -66 lines 0 comments Download
A device/bluetooth/bluetooth_adapter_android.cc View 1 chunk +138 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_adapter_android_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
scheib
5 years, 7 months ago (2015-04-29 00:13:12 UTC) #3
armansito
https://codereview.chromium.org/1080593007/diff/20001/device/BUILD.gn File device/BUILD.gn (right): https://codereview.chromium.org/1080593007/diff/20001/device/BUILD.gn#newcode19 device/BUILD.gn:19: "bluetooth/bluetooth_adapter_android_unittest.mm", Did you mean .cc? https://codereview.chromium.org/1080593007/diff/20001/device/bluetooth/bluetooth_adapter_android.h File device/bluetooth/bluetooth_adapter_android.h (right): ...
5 years, 7 months ago (2015-04-29 01:17:29 UTC) #4
scheib
https://codereview.chromium.org/1080593007/diff/20001/device/BUILD.gn File device/BUILD.gn (right): https://codereview.chromium.org/1080593007/diff/20001/device/BUILD.gn#newcode19 device/BUILD.gn:19: "bluetooth/bluetooth_adapter_android_unittest.mm", On 2015/04/29 01:17:28, armansito wrote: > Did you ...
5 years, 7 months ago (2015-04-29 01:35:14 UTC) #5
armansito
lgtm
5 years, 7 months ago (2015-04-29 01:41:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080593007/40001
5 years, 7 months ago (2015-04-29 02:06:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-04-29 06:09:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080593007/40001
5 years, 7 months ago (2015-04-29 20:46:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-04-29 21:32:01 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:33:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35fbdd40277f2d4806abe3c90705f35d1e66bd8c
Cr-Commit-Position: refs/heads/master@{#327562}

Powered by Google App Engine
This is Rietveld 408576698