DescriptionPass in a non-null CertVerifier into SSLClientSocket.
SslHmacChannelAuthenticator passes in a null one which crashes but the
IsAllowedBadCert check, as well as inconsistent ability to use X509Certificate
in the sandbox masks the issue most of the time.
This also fixes FakeStreamSocket to propogate disconnects to the peer, which is
needed to add a test for this case. (If SSLClientSocket doesn't like a
certificate, it just ceremoniously disconnects the connection right after the
handshake.) This test crashed before this CL outside the sandbox. (Inside the
sandbox, it's possible that it worked on some platforms due to the sandbox
breaking net::X509Certificate. I didn't do a survey.)
BUG=none
Committed: https://crrev.com/9bbf3290520788bfe634a286a30965cd43f4dd78
Cr-Commit-Position: refs/heads/master@{#326886}
Patch Set 1 #Patch Set 2 : revise comment (try jobs on patch set 1) #
Total comments: 7
Patch Set 3 : fix comment typo #
Messages
Total messages: 13 (5 generated)
|