Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1080553002: ScreenOrientationController to start observing even without an internal display. (Closed)

Created:
5 years, 8 months ago by jonross
Modified:
5 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank, tdanderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScreenOrientationController to start observing even without an internal display. Ozone loads display configurations asynchronously. Due to this the internal display is not always known when Maximize Mode is triggered. Update ScreenOrientationController to become an observer even when there is no internal display ready yet. That way, once it becomes ready, it is able to process accelerometer events. TEST=ScreenOrientationControllerTest.InternalDisplayNotAvailableAtStartup BUG=chrome-os-partner:38796 Committed: https://crrev.com/31fed68a524d49f99cebf02dca6ad49019e9900c Cr-Commit-Position: refs/heads/master@{#325298}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M ash/content/display/screen_orientation_controller_chromeos.cc View 1 3 chunks +12 lines, -10 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jonross
Hi Oshima, Could you provide an owners review for this change? I've updated ScreenOrientationController to ...
5 years, 8 months ago (2015-04-10 15:01:22 UTC) #3
oshima
I updated the bug. Please let me know if you still want to proceed.
5 years, 8 months ago (2015-04-10 20:16:09 UTC) #4
jonross
On 2015/04/10 20:16:09, oshima wrote: > I updated the bug. Please let me know if ...
5 years, 8 months ago (2015-04-13 14:13:52 UTC) #5
oshima
lgtm https://codereview.chromium.org/1080553002/diff/20001/ash/content/display/screen_orientation_controller_chromeos.cc File ash/content/display/screen_orientation_controller_chromeos.cc (right): https://codereview.chromium.org/1080553002/diff/20001/ash/content/display/screen_orientation_controller_chromeos.cc#newcode217 ash/content/display/screen_orientation_controller_chromeos.cc:217: // Mode has started. Always start observing. Can ...
5 years, 8 months ago (2015-04-15 18:47:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080553002/40001
5 years, 8 months ago (2015-04-15 20:12:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-15 20:51:25 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 20:53:20 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31fed68a524d49f99cebf02dca6ad49019e9900c
Cr-Commit-Position: refs/heads/master@{#325298}

Powered by Google App Engine
This is Rietveld 408576698