Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1080523002: Oilpan: adjust AnimationTimeline finalization. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: adjust AnimationTimeline finalization. With Oilpan, explicitly disconnecting its animation players is not needed; the ExecutionContext's weak reference will be transparently take care of this instead. While here, merge the timeline finalization steps into a detach operation for AnimationPlayer. TBR=dstockwell,oilpan-reviews BUG=472307 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/core/animation/AnimationPlayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationTimeline.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look.
5 years, 8 months ago (2015-04-10 13:03:46 UTC) #2
sof
tbr'ing based on https://codereview.chromium.org/1054823002/#msg12 + bot redness.
5 years, 8 months ago (2015-04-10 14:21:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080523002/1
5 years, 8 months ago (2015-04-10 14:22:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=193552
5 years, 8 months ago (2015-04-10 14:53:49 UTC) #6
haraken
5 years, 8 months ago (2015-04-10 16:08:41 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698