chrome/browser/extensions/api/downloads/downloads_api_unittest.cc - Issue 10805020: Kill DownloadItem::IsOtr()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

Issue 10805020: Kill DownloadItem::IsOtr() (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

index ae7288bd42aacf9804962c2ed940aad799210ead..0775087230b40a36b0fac50d6da169fe65eade1a 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

@@ -1349,13 +1349,11 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,

GoOffTheRecord();

DownloadItem* off_item = CreateSlowTestDownload();

ASSERT_TRUE(off_item);

- ASSERT_TRUE(off_item->IsOtr());

off_item_arg = DownloadItemIdAsArgList(off_item);

GoOnTheRecord();

DownloadItem* on_item = CreateSlowTestDownload();

ASSERT_TRUE(on_item);

- ASSERT_FALSE(on_item->IsOtr());

on_item_arg = DownloadItemIdAsArgList(on_item);

ASSERT_TRUE(on_item->GetFullPath() != off_item->GetFullPath());