chrome/browser/download/download_history.cc - Issue 10805020: Kill DownloadItem::IsOtr()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_history.cc

Issue 10805020: Kill DownloadItem::IsOtr() (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_history.cc

diff --git a/chrome/browser/download/download_history.cc b/chrome/browser/download/download_history.cc

index d98945f259a03181206a35f977cb271234386688..b4aa58279c12f1edceca6d6030693599df8c27eb 100644

--- a/chrome/browser/download/download_history.cc

+++ b/chrome/browser/download/download_history.cc

@@ -80,8 +80,7 @@ void DownloadHistory::AddEntry(

// the neck first. YMMV.

HistoryService* hs = HistoryServiceFactory::GetForProfileIfExists(

profile_, Profile::EXPLICIT_ACCESS);

- if (download_item->IsOtr() ||

- download_crx_util::IsExtensionDownload(*download_item) ||

+ if (download_crx_util::IsExtensionDownload(*download_item) ||

download_item->IsTemporary() || !hs) {

callback.Run(download_item->GetId(), GetNextFakeDbHandle());

return;