chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc - Issue 1080453002: Always destroy CrxInstaller on the UI Thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

Issue 1080453002: Always destroy CrxInstaller on the UI Thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix CrOZ Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_data.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | chrome/browser/extensions/crx_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

diff --git a/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc b/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

index b71ab94c8bb2ba6fad6a8bf67728dec602a9042f..89e2d0a037e82abf0b0ea0c3684430c25b46e479 100644

--- a/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

+++ b/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

@@ -17,7 +17,10 @@ KioskExternalUpdateValidator::KioskExternalUpdateValidator(

const extensions::CRXFileInfo& file,

const base::FilePath& crx_unpack_dir,

const base::WeakPtr<KioskExternalUpdateValidatorDelegate>& delegate)

- : backend_task_runner_(backend_task_runner),

+ : SandboxedUnpackerClient(

+ content::BrowserThread::GetMessageLoopProxyForThread(

+ content::BrowserThread::UI)),

+ backend_task_runner_(backend_task_runner),

crx_file_(file),

crx_unpack_dir_(crx_unpack_dir),

delegate_(delegate) {