Always destroy CrxInstaller on the UI Thread

extensions/browser/sandboxed_unpacker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/extensions_test.h"
 #include "extensions/browser/sandboxed_unpacker.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_paths.h"
 #include "extensions/common/switches.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace extensions {
 
 class MockSandboxedUnpackerClient : public SandboxedUnpackerClient {
  public:
+  MockSandboxedUnpackerClient(const scoped_refptr<base::MessageLoopProxy>& loop)
+      : SandboxedUnpackerClient(loop) {}
+
   void WaitForUnpack() {
     scoped_refptr<content::MessageLoopRunner> runner =
         new content::MessageLoopRunner;
     quit_closure_ = runner->QuitClosure();
     runner->Run();
   }
 
   base::FilePath temp_dir() const { return temp_dir_; }
   base::string16 unpack_err() const { return error_; }
 
@@ skipping 22 matching lines @@
 class SandboxedUnpackerTest : public ExtensionsTest {
  public:
   void SetUp() override {
     ExtensionsTest::SetUp();
     ASSERT_TRUE(extensions_dir_.CreateUniqueTempDir());
     browser_threads_.reset(new content::TestBrowserThreadBundle(
         content::TestBrowserThreadBundle::IO_MAINLOOP));
     in_process_utility_thread_helper_.reset(
         new content::InProcessUtilityThreadHelper);
     // It will delete itself.
-    client_ = new MockSandboxedUnpackerClient;
+    client_ = new MockSandboxedUnpackerClient(
+        content::BrowserThread::GetMessageLoopProxyForThread(
+            content::BrowserThread::UI));
   }
 
   void TearDown() override {
     // Need to destruct SandboxedUnpacker before the message loop since
     // it posts a task to it.
     sandboxed_unpacker_ = NULL;
     base::RunLoop().RunUntilIdle();
     ExtensionsTest::TearDown();
   }
 
@@ skipping 62 matching lines @@
   EXPECT_EQ(base::string16(), GetInstallError());
 }
 
 TEST_F(SandboxedUnpackerTest, SkipHashCheck) {
   SetupUnpacker("good_l10n.crx", "badhash");
   // Check that there is no error message.
   EXPECT_EQ(base::string16(), GetInstallError());
 }
 
 }  // namespace extensions