Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/browser/extensions/crx_installer.h

Issue 1080453002: Always destroy CrxInstaller on the UI Thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Less plumbing. More comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 363
364 // The temp directory extension resources were unpacked to. We own this and 364 // The temp directory extension resources were unpacked to. We own this and
365 // must delete it when we are done with it. 365 // must delete it when we are done with it.
366 base::FilePath temp_dir_; 366 base::FilePath temp_dir_;
367 367
368 // The frontend we will report results back to. 368 // The frontend we will report results back to.
369 base::WeakPtr<ExtensionService> service_weak_; 369 base::WeakPtr<ExtensionService> service_weak_;
370 370
371 // The client we will work with to do the installation. This can be NULL, in 371 // The client we will work with to do the installation. This can be NULL, in
372 // which case the install is silent. 372 // which case the install is silent.
373 // NOTE: we may be deleted on the file thread. To ensure the UI is deleted on 373 scoped_ptr<ExtensionInstallPrompt> client_;
374 // the main thread we don't use a scoped_ptr here.
375 ExtensionInstallPrompt* client_;
376 374
377 // The root of the unpacked extension directory. This is a subdirectory of 375 // The root of the unpacked extension directory. This is a subdirectory of
378 // temp_dir_, so we don't have to delete it explicitly. 376 // temp_dir_, so we don't have to delete it explicitly.
379 base::FilePath unpacked_extension_root_; 377 base::FilePath unpacked_extension_root_;
380 378
381 // True when the CRX being installed was just downloaded. 379 // True when the CRX being installed was just downloaded.
382 // Used to trigger extra checks before installing. 380 // Used to trigger extra checks before installing.
383 bool apps_require_extension_mime_type_; 381 bool apps_require_extension_mime_type_;
384 382
385 // Allows for the possibility of a normal install (one in which a |client| 383 // Allows for the possibility of a normal install (one in which a |client|
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 431
434 // Performs requirements, policy and blacklist checks on the extension. 432 // Performs requirements, policy and blacklist checks on the extension.
435 ExtensionInstallChecker install_checker_; 433 ExtensionInstallChecker install_checker_;
436 434
437 DISALLOW_COPY_AND_ASSIGN(CrxInstaller); 435 DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
438 }; 436 };
439 437
440 } // namespace extensions 438 } // namespace extensions
441 439
442 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 440 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698