Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1080393009: Make pixel_snap GMs incur less platform-specific variation (Closed)

Created:
5 years, 8 months ago by bsalomon
Modified:
5 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make pixel_snap GMs incur less platform-specific variation Committed: https://skia.googlesource.com/skia/+/c6534a28a634e501075fde2b483bf62336276cef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -41 lines) Patch
M gm/pixelsnap.cpp View 2 chunks +31 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
5 years, 8 months ago (2015-04-22 18:19:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080393009/1
5 years, 8 months ago (2015-04-22 18:20:07 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-22 18:20:09 UTC) #5
bsalomon
The measureText calls were a mistake, they produce different offsets for the labels depending on ...
5 years, 8 months ago (2015-04-22 18:28:02 UTC) #6
robertphillips
lgtm
5 years, 8 months ago (2015-04-22 18:33:03 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 18:34:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c6534a28a634e501075fde2b483bf62336276cef

Powered by Google App Engine
This is Rietveld 408576698