Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1080393004: [es6] Function.prototype.name should be the empty string (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Function.prototype.name should be the empty string ES6 specifies the function name property (it was not part of ES5) and it specifies the name of Function.prototype to the empty string ("" and not "Empty"). This makes us match Firefox, Safari and IE developer preview. BUG=v8:4033 LOG=N R=adamk@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/d0db1c39cab264339ed32ea63912b7e814a24993 Cr-Commit-Position: refs/heads/master@{#28021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/mjsunit/es6/function-name-configurable.js View 2 chunks +3 lines, -3 lines 0 comments Download
A test/mjsunit/es6/function-prototype-name.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
arv (Not doing code reviews)
PTAL
5 years, 8 months ago (2015-04-21 19:57:20 UTC) #1
adamk
lgtm Did you find any history of how this happened?
5 years, 8 months ago (2015-04-21 20:02:54 UTC) #2
arv (Not doing code reviews)
On 2015/04/21 20:02:54, adamk wrote: > lgtm > > Did you find any history of ...
5 years, 8 months ago (2015-04-21 20:25:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080393004/1
5 years, 8 months ago (2015-04-21 20:26:17 UTC) #5
adamk
Sigh, looks like Blink tests encode this, as the __proto__ of functions that get pretty-printed.
5 years, 8 months ago (2015-04-21 23:15:48 UTC) #6
arv (Not doing code reviews)
On 2015/04/21 23:15:48, adamk wrote: > Sigh, looks like Blink tests encode this, as the ...
5 years, 8 months ago (2015-04-21 23:17:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080393004/1
5 years, 8 months ago (2015-04-22 16:57:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080393004/1
5 years, 8 months ago (2015-04-22 23:04:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 00:29:46 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 00:30:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0db1c39cab264339ed32ea63912b7e814a24993
Cr-Commit-Position: refs/heads/master@{#28021}

Powered by Google App Engine
This is Rietveld 408576698