Issue 1080363002: NaCl: Update revision in DEPS, bd095c3 -> 8e69819

Issue 1080363002: NaCl: Update revision in DEPS, bd095c3 -> 8e69819 (Closed)

Created:
5 years, 8 months ago by Mark Seaborn

Modified:
5 years, 8 months ago

Reviewers:
bartfab (slow), Derek Schuff

CC:
chromium-reviews, Derek Schuff, hidehiko, JF, jvoung (off chromium), native-client-reviews_googlegroups.com, petarj, Petr Hosek, shinyak, teravest

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

NaCl: Update revision in DEPS, bd095c3 -> 8e69819 This pulls in the following Native Client changes: 36f7841: (petarj@mips.com) [MIPS] Change TEST_IS_LOCK_FREE for 64bit types c827ec5: (dschuff@chromium.org) Add torture test configs for nacl-clang 7005393: (dschuff@chromium.org) Add missing EH failures exclusion file for clang 9b89306: (teravest@chromium.org) Revert of Remove NACL_BUILD_ARCH_MAP (patchset #1 id:1 of https://codereview.chromium.org/1039253003/) 69c5742: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS 57f974d: (dschuff@chromium.org) Update and triage gcc torture known failures 10a7211: (shinyak@chromium.org) Check archive on Windows. da6385f: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS 0a06a29: (jvoung@chromium.org) Make the torture test known failures for PNaCl a bit stricter. 6a47074: (dschuff@chromium.org) Run compiler_rt test suite on FYI bots 021d15a: (jvoung@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS 9b7cee1: (sbc@chromium.org) Cleanup libnacl's pthread.h 3a908f6: (sbc@chromium.org) Add pthead_condattr_* function to libpthread 002a793: (dschuff@chromium.org) FYI bot script: Fixes for compiler-rt test suite 5e87ba2: (dschuff@chromium.org) Remove libstdc++ tests from toolchain_tests 4d31bac: (dschuff@chromium.org) Fix breakage from 5e87ba2d2c3376efcec763954b5cb81c332d20d1 d25fdca: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS 0ebde97: (dschuff@chromium.org) Remove libstdc++ support from PNaCl toolchain 9c667ae: (dschuff@chromium.org) Update revision for PNaCl 2ef8b63: (dschuff@chromium.org) Run ARM tests first on the PNaCl toolchain linux64 bot 40b7e45: (dschuff@chromium.org) Run memcpy_move_set test with and without -fno-builtin 11953a3: (phosek@chromium.org) Use depot_tools version of Git on Windows for toolchain build 6863b50: (sbc@chromium.org) Add 'arm_trusted' to the 'nacl_core_sdk' package list 4dfff0b: (jvoung@chromium.org) Have CMake LLVM build share CFLAGS/CXXFLAGS with autoconf (e.g., libc++ flags). 47e9502: (hidehiko@chromium.org) Non-SFI mode: Small update for nacl_helper_nonsfi. 8e69819: (sbc@chromium.org) Add O_EXCL support to sel_ldr open syscall Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/bd095c3ad5f1f25a9c6f44b7f38cec89383a5c33..8e6981959f76f5480f74b2b4819d3b260b1b2062 BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build Committed: https://crrev.com/00471ef5d3d886d71b022ad6eaac317e6c9d5e08 Cr-Commit-Position: refs/heads/master@{#325177}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 21 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080363002/1

5 years, 8 months ago (2015-04-14 20:36:39 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/1584)

5 years, 8 months ago (2015-04-14 23:51:19 UTC) #7

Sam Clegg

On 2015/04/14 23:51:19, I haz the power (commit-bot) wrote: > Try jobs failed on following ...

5 years, 8 months ago (2015-04-15 01:16:37 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080363002/1

5 years, 8 months ago (2015-04-15 02:38:22 UTC) #10

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/00471ef5d3d886d71b022ad6eaac317e6c9d5e08 Cr-Commit-Position: refs/heads/master@{#325177}

5 years, 8 months ago (2015-04-15 02:40:07 UTC) #12

bartfab (slow)

A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1089163003/ by bartfab@chromium.org. ...

5 years, 8 months ago (2015-04-15 07:52:51 UTC) #13

Mark Seaborn

On 14 April 2015 at 21:52, <bartfab@chromium.org> wrote: > A revert of this CL (patchset ...

5 years, 8 months ago (2015-04-15 16:45:14 UTC) #14

Mark Seaborn

On 14 April 2015 at 21:52, <bartfab@chromium.org> wrote: > A revert of this CL (patchset ...

5 years, 8 months ago (2015-04-15 16:45:16 UTC) #15

bartfab (slow)

On 04/15/2015 06:44 PM, Mark Seaborn wrote: > On 14 April 2015 at 21:52, <bartfab@chromium.org> ...

5 years, 8 months ago (2015-04-16 12:14:50 UTC) #16

bartfab (slow)

On 04/15/2015 06:44 PM, Mark Seaborn wrote: > On 14 April 2015 at 21:52, <bartfab@chromium.org> ...

5 years, 8 months ago (2015-04-16 12:14:52 UTC) #17

+Paweł, others to BCC: issue 89099 <https://code.google.com/p/chromium/issues/detail?id=98099> leads me to believe he may be able ...

5 years, 8 months ago (2015-04-16 14:10:23 UTC) #18

Message was sent while issue was closed.

+Paweł, others to BCC: issue 89099
<https://code.google.com/p/chromium/issues/detail?id=98099> leads me to
believe he may be able to help figure out why this wasn't caught in
presubmit, and how this can be fixed so that CQ fails next time instead of
needing a revert.

On Thu, Apr 16, 2015 at 1:14 PM, Bartosz Fabianowski <bartfab@chromium.org>
wrote:

> On 04/15/2015 06:44 PM, Mark Seaborn wrote:
>
>> On 14 April 2015 at 21:52, <bartfab@chromium.org> wrote:
>>
>>  A revert of this CL (patchset #1 id:1) has been created in
>>> https://codereview.chromium.org/1089163003/ by bartfab@chromium.org.
>>>
>>> The reason for reverting is: Breaks check_licenses on Linux:
>>>
>>> Using base directory: src
>>> Checking: src
>>>
>>> 'native_client/toolchain/linux_x86/arm_trusted/usr/
>>> include/X11/Xwindows.h'
>>> has
>>> non-whitelisted license 'BSD MIT/X11 (BSD like)'
>>> 'native_client/toolchain/linux_x86/arm_trusted/usr/
>>> include/X11/Xwinsock.h'
>>> has
>>> non-whitelisted license 'BSD MIT/X11 (BSD like)'
>>> 'native_client/toolchain/linux_x86/arm_trusted/usr/
>>> include/gdk-pixbuf-2.0/gdk-pixbuf-xlib/gdk-pixbuf-xlibrgb.h'
>>> has non-whitelisted license 'MPL (v1.1) LGPL (unversioned/unknown
>>> version)'.
>>>
>>
>>
>> Is there a Buildbot that runs this check?  If so, can you give me the link
>> to the Buildbot run that failed?  Is there a trybot that runs the licence
>> check as well?
>>
>
> Sorry, I have no idea whether there are any trybots or buildbots that run
> this check. I only saw it fail on the waterfall directly.
>
>
>> Cheers,
>> Mark
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

+Paweł, others to BCC: issue 89099 <https://code.google.com/p/chromium/issues/detail?id=98099> leads me to believe he may be able ...

5 years, 8 months ago (2015-04-16 14:10:24 UTC) #19

bartfab (slow)

Note that this was worse than just a revert: The NaCl toolchain is downloaded as ...

5 years, 8 months ago (2015-04-16 14:31:28 UTC) #20

Message was sent while issue was closed.

Note that this was worse than just a revert:

The NaCl toolchain is downloaded as a tar file and unpacked into the 
src/ directory on the build machine. After the revert, even a clobber 
build did not remove the unpacked files. A trooper had to SSH into each 
affected bot and clean up by hand.

- Bartosz

On 04/16/2015 04:10 PM, JF Bastien wrote:
> +Paweł, others to BCC: issue 89099
> <https://code.google.com/p/chromium/issues/detail?id=98099> leads me to
> believe he may be able to help figure out why this wasn't caught in
> presubmit, and how this can be fixed so that CQ fails next time instead
> of needing a revert.
>
> On Thu, Apr 16, 2015 at 1:14 PM, Bartosz Fabianowski
> <bartfab@chromium.org <mailto:bartfab@chromium.org>> wrote:
>
>     On 04/15/2015 06:44 PM, Mark Seaborn wrote:
>
>         On 14 April 2015 at 21:52, <bartfab@chromium.org
>         <mailto:bartfab@chromium.org>> wrote:
>
>             A revert of this CL (patchset #1 id:1) has been created in
>             https://codereview.chromium.__org/1089163003/
>             <https://codereview.chromium.org/1089163003/> by
>             bartfab@chromium.org <mailto:bartfab@chromium.org>.
>
>             The reason for reverting is: Breaks check_licenses on Linux:
>
>             Using base directory: src
>             Checking: src
>
>            
'native_client/toolchain/__linux_x86/arm_trusted/usr/__include/X11/Xwindows.h'
>             has
>             non-whitelisted license 'BSD MIT/X11 (BSD like)'
>            
'native_client/toolchain/__linux_x86/arm_trusted/usr/__include/X11/Xwinsock.h'
>             has
>             non-whitelisted license 'BSD MIT/X11 (BSD like)'
>             'native_client/toolchain/__linux_x86/arm_trusted/usr/
>             include/gdk-pixbuf-2.0/gdk-__pixbuf-xlib/gdk-pixbuf-__xlibrgb.h'
>             has non-whitelisted license 'MPL (v1.1) LGPL
>             (unversioned/unknown
>             version)'.
>
>
>
>         Is there a Buildbot that runs this check?  If so, can you give
>         me the link
>         to the Buildbot run that failed?  Is there a trybot that runs
>         the licence
>         check as well?
>
>
>     Sorry, I have no idea whether there are any trybots or buildbots
>     that run this check. I only saw it fail on the waterfall directly.
>
>
>         Cheers,
>         Mark
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

bartfab (slow)

5 years, 8 months ago (2015-04-16 14:31:29 UTC) #21

Message was sent while issue was closed.

Note that this was worse than just a revert:

The NaCl toolchain is downloaded as a tar file and unpacked into the 
src/ directory on the build machine. After the revert, even a clobber 
build did not remove the unpacked files. A trooper had to SSH into each 
affected bot and clean up by hand.

- Bartosz

On 04/16/2015 04:10 PM, JF Bastien wrote:
> +Paweł, others to BCC: issue 89099
> <https://code.google.com/p/chromium/issues/detail?id=98099> leads me to
> believe he may be able to help figure out why this wasn't caught in
> presubmit, and how this can be fixed so that CQ fails next time instead
> of needing a revert.
>
> On Thu, Apr 16, 2015 at 1:14 PM, Bartosz Fabianowski
> <bartfab@chromium.org <mailto:bartfab@chromium.org>> wrote:
>
>     On 04/15/2015 06:44 PM, Mark Seaborn wrote:
>
>         On 14 April 2015 at 21:52, <bartfab@chromium.org
>         <mailto:bartfab@chromium.org>> wrote:
>
>             A revert of this CL (patchset #1 id:1) has been created in
>             https://codereview.chromium.__org/1089163003/
>             <https://codereview.chromium.org/1089163003/> by
>             bartfab@chromium.org <mailto:bartfab@chromium.org>.
>
>             The reason for reverting is: Breaks check_licenses on Linux:
>
>             Using base directory: src
>             Checking: src
>
>            
'native_client/toolchain/__linux_x86/arm_trusted/usr/__include/X11/Xwindows.h'
>             has
>             non-whitelisted license 'BSD MIT/X11 (BSD like)'
>            
'native_client/toolchain/__linux_x86/arm_trusted/usr/__include/X11/Xwinsock.h'
>             has
>             non-whitelisted license 'BSD MIT/X11 (BSD like)'
>             'native_client/toolchain/__linux_x86/arm_trusted/usr/
>             include/gdk-pixbuf-2.0/gdk-__pixbuf-xlib/gdk-pixbuf-__xlibrgb.h'
>             has non-whitelisted license 'MPL (v1.1) LGPL
>             (unversioned/unknown
>             version)'.
>
>
>
>         Is there a Buildbot that runs this check?  If so, can you give
>         me the link
>         to the Buildbot run that failed?  Is there a trybot that runs
>         the licence
>         check as well?
>
>
>     Sorry, I have no idea whether there are any trybots or buildbots
>     that run this check. I only saw it fail on the waterfall directly.
>
>
>         Cheers,
>         Mark
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages