src/hydrogen-instructions.cc - Issue 108033002: Bugfix: HCheckInstanceType::GetCheckMaskAndTag used an incorrect mask.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 108033002: Bugfix: HCheckInstanceType::GetCheckMaskAndTag used an incorrect mask. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index 3ab9576515e4efbf81e723fb0ab3dd4fdc047c8e..1ed8df7c15553d64d0979b1d5845ad8efee88eee 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -1533,7 +1533,7 @@ void HCheckInstanceType::GetCheckMaskAndTag(uint8_t* mask, uint8_t* tag) {

*tag = kStringTag;

return;

case IS_INTERNALIZED_STRING:

- *mask = kIsNotInternalizedMask;

+ *mask = kIsNotStringMask | kIsNotInternalizedMask;

*tag = kInternalizedTag;

return;

default:

« no previous file with comments | « no previous file | test/mjsunit/regress/internalized-string-not-equal.js » ('j') | no next file with comments »