Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 108033002: Bugfix: HCheckInstanceType::GetCheckMaskAndTag used an incorrect mask. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/internalized-string-not-equal.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1515 matching lines...) Expand 10 before | Expand all | Expand 10 after
1526 1526
1527 1527
1528 void HCheckInstanceType::GetCheckMaskAndTag(uint8_t* mask, uint8_t* tag) { 1528 void HCheckInstanceType::GetCheckMaskAndTag(uint8_t* mask, uint8_t* tag) {
1529 ASSERT(!is_interval_check()); 1529 ASSERT(!is_interval_check());
1530 switch (check_) { 1530 switch (check_) {
1531 case IS_STRING: 1531 case IS_STRING:
1532 *mask = kIsNotStringMask; 1532 *mask = kIsNotStringMask;
1533 *tag = kStringTag; 1533 *tag = kStringTag;
1534 return; 1534 return;
1535 case IS_INTERNALIZED_STRING: 1535 case IS_INTERNALIZED_STRING:
1536 *mask = kIsNotInternalizedMask; 1536 *mask = kIsNotStringMask | kIsNotInternalizedMask;
1537 *tag = kInternalizedTag; 1537 *tag = kInternalizedTag;
1538 return; 1538 return;
1539 default: 1539 default:
1540 UNREACHABLE(); 1540 UNREACHABLE();
1541 } 1541 }
1542 } 1542 }
1543 1543
1544 1544
1545 void HCheckMaps::HandleSideEffectDominator(GVNFlag side_effect, 1545 void HCheckMaps::HandleSideEffectDominator(GVNFlag side_effect,
1546 HValue* dominator) { 1546 HValue* dominator) {
(...skipping 2874 matching lines...) Expand 10 before | Expand all | Expand 10 after
4421 break; 4421 break;
4422 case kExternalMemory: 4422 case kExternalMemory:
4423 stream->Add("[external-memory]"); 4423 stream->Add("[external-memory]");
4424 break; 4424 break;
4425 } 4425 }
4426 4426
4427 stream->Add("@%d", offset()); 4427 stream->Add("@%d", offset());
4428 } 4428 }
4429 4429
4430 } } // namespace v8::internal 4430 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/internalized-string-not-equal.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698