Issue 108033002: Bugfix: HCheckInstanceType::GetCheckMaskAndTag used an incorrect mask.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108033002: Bugfix: HCheckInstanceType::GetCheckMaskAndTag used an incorrect mask. (Closed)

Created:
7 years ago by mvstanton

Modified:
7 years ago

Reviewers:
Weiliang, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Bugfix: HCheckInstanceType::GetCheckMaskAndTag used an incorrect mask. The mask to check for an internalized string was incorrectly formed. Hat tip to Weiliang Lin for discovering the bug. BUG=v8:3038 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18265

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/internalized-string-not-equal.js	View		1 chunk	+10 lines, -9 lines	0 comments	Download

Total messages: 6 (0 generated)

Dmitry Lomov (no reviews)

On 2013/12/06 09:17:52, Yang wrote: > On 2013/12/06 09:17:41, Yang wrote: > > LGTM. > ...

7 years ago (2013-12-06 09:29:55 UTC) #4

mvstanton

Thx, I filed https://code.google.com/p/v8/issues/detail?id=3038 to track/triage.

7 years ago (2013-12-06 09:39:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r18265.