Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 1080323002: Prevent analysis exceptions from crashing the completion engine. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index 70808d596e99a0557eb0265b99cbcf0b0929e794..8da57abad0d9d3f66328a0da7297171823b09482 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -157,7 +157,7 @@ class CompletionDomainHandler implements RequestHandler {
String computeTag = 'computeCache';
performance.logStartTime(computeTag);
CompletionManager manager = completionManagerFor(context, source);
- manager.computeCache().then((bool success) {
+ manager.computeCache().catchError((_) => false).then((bool success) {
performance.logElapseTime(computeTag);
performance.complete('priorityChanged caching: $success');
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698