Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1080303002: Revert "Remove early bail-out in VisitWeakList to investigate chrasher." (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Remove early bail-out in VisitWeakList to investigate chrasher." > BUG=468601 > LOG=n > > Review URL: https://codereview.chromium.org/1016353002 > > Cr-Commit-Position: refs/heads/master@{#27317} R=hpayer@chromium.org BUG=v8:3996, chromium:468601 LOG=n Committed: https://crrev.com/835eeafe32f442d7b43fe175237de2c70ed7ceef Cr-Commit-Position: refs/heads/master@{#27814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/heap/objects-visiting.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-14 09:29:16 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-14 10:37:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080303002/1
5 years, 8 months ago (2015-04-14 10:54:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 10:55:30 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/835eeafe32f442d7b43fe175237de2c70ed7ceef Cr-Commit-Position: refs/heads/master@{#27814}
5 years, 8 months ago (2015-04-14 10:55:39 UTC) #6
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-16 20:59:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1092783002/ by jochen@chromium.org.

The reason for reverting is: Still doesn't work.

Powered by Google App Engine
This is Rietveld 408576698