Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 1080263004: MIPS: Use Cells to check prototype chain validity (disabled by default). (Closed)

Created:
5 years, 8 months ago by balazs.kilvady
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Use Cells to check prototype chain validity (disabled by default). Original commit message: The cells are stored as (hidden) properties on prototype objects. When a prototype object changes its map, then both its own validity cell and those of all "downstream" prototypes are invalidated; handlers for a given receiver embed the currently valid cell for that receiver's prototype during their compilation and check it on execution. Other changes in this CL: - Made Map::SetPrototype static (for GC safety of |this|). - For prototype maps, keep track of the prototype object using them. This is required for being able to find and invalidate "downstream" prototypes' cells. - Ensure that prototype maps are never shared, even if they are slow. This is required for the above. - Minor "const" cleanup for a few Map field accessors. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -32 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 6 chunks +52 lines, -16 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 6 chunks +52 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
paul.l...
l-g-t-m However, like parent CL, it does not pass tests with flag on.
5 years, 8 months ago (2015-04-14 17:03:18 UTC) #2
paul.l...
On 2015/04/14 17:03:18, paul.l... wrote: > l-g-t-m > > However, like parent CL, it does ...
5 years, 8 months ago (2015-04-15 01:59:48 UTC) #3
Jakob Kummerow
5 years, 8 months ago (2015-04-15 09:34:20 UTC) #4
On 2015/04/15 01:59:48, paul.l... wrote:
> On 2015/04/14 17:03:18, paul.l... wrote:
> > l-g-t-m
> > 
> > However, like parent CL, it does not pass tests with flag on.
> 
> Testing error on my part, the CL & its parent are fine.

Thanks for the port; I've merged it into the main CL.

Powered by Google App Engine
This is Rietveld 408576698