Issue 1080253003: VectorICs: recreate feedback vector if scoping changes on recompile.

Issue 1080253003: VectorICs: recreate feedback vector if scoping changes on recompile. (Closed)

Created:
5 years, 8 months ago by mvstanton

Modified:
5 years, 8 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

VectorICs: recreate feedback vector if scoping changes on recompile. BUG=476488 LOG=N R=jarin@chromium.org Committed: https://crrev.com/2ebb794b4fd65f4f1744a3be0e4aba933c1c1fc1 Cr-Commit-Position: refs/heads/master@{#27817}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
M	src/compiler.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/type-feedback-vector.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/type-feedback-vector.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-476488.js	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

mvstanton

Hi Jaro, here is the fix, thanks for bisecting! --Michael

5 years, 8 months ago (2015-04-14 10:54:53 UTC) #1

Jarin

On 2015/04/14 10:54:53, mvstanton wrote: > Hi Jaro, here is the fix, thanks for bisecting! ...

5 years, 8 months ago (2015-04-14 11:48:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080253003/20001

5 years, 8 months ago (2015-04-14 12:05:53 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-14 12:31:48 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/2ebb794b4fd65f4f1744a3be0e4aba933c1c1fc1
Cr-Commit-Position: refs/heads/master@{#27817}