Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1080233003: Chromecast: CmaMessageFilterHost SetCdm threading change. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
Reviewers:
lcwu1, servolk
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: CmaMessageFilterHost SetCdm threading change. * Revert change to do a multi-step thread-hopping destroy. This was not a solid idea in the first place. * Removes UI-thread member function from CmaMessageFilterHost (SetCdmOnUiThread) and makes it static. * Checks validity of MediaPipelineHost reference on CMA thread before invoking MediaPipelineHost::SetCdm by maintaining an extra map of MediaPipelineHost references exclusively on the CMA thread. R=lcwu@chromium.org,servolk@chromium.org BUG=internal b/20188230 Committed: https://crrev.com/06ad6451eae0062a97e01570f1c403ceedc7dfff Cr-Commit-Position: refs/heads/master@{#325949}

Patch Set 1 #

Patch Set 2 : rename MessageLoopProxy references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -44 lines) Patch
M chromecast/browser/media/cma_message_filter_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromecast/browser/media/cma_message_filter_host.cc View 1 6 chunks +95 lines, -41 lines 0 comments Download
M chromecast/browser/media/cma_message_loop.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chromecast/browser/media/cma_message_loop.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
gunsch
5 years, 8 months ago (2015-04-20 20:04:02 UTC) #1
lcwu1
lgtm
5 years, 8 months ago (2015-04-20 22:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080233003/1
5 years, 8 months ago (2015-04-20 22:52:23 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/57557)
5 years, 8 months ago (2015-04-20 23:25:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080233003/20001
5 years, 8 months ago (2015-04-20 23:48:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 00:13:52 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 00:14:45 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06ad6451eae0062a97e01570f1c403ceedc7dfff
Cr-Commit-Position: refs/heads/master@{#325949}

Powered by Google App Engine
This is Rietveld 408576698