chrome/browser/ui/cocoa/history_menu_bridge.mm - Issue 10802066: Adds support for saving favicon size into history database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/history_menu_bridge.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_bridge.mm b/chrome/browser/ui/cocoa/history_menu_bridge.mm

index 22e83c4eb181e283788f124ff9d4f70fcb3323b7..d6120a2f3d4712ddf21a9a4b24d978b700e9ae7e 100644

--- a/chrome/browser/ui/cocoa/history_menu_bridge.mm

+++ b/chrome/browser/ui/cocoa/history_menu_bridge.mm

@@ -471,8 +471,8 @@ void HistoryMenuBridge::GotFaviconData(FaviconService::Handle handle,

// TODO(rsesek): Is there an easier way to do this?

SkBitmap icon;

if (favicon.is_valid() &&

- gfx::PNGCodec::Decode(favicon.image_data->front(),

- favicon.image_data->size(), &icon)) {

+ gfx::PNGCodec::Decode(favicon.bitmap_data->front(),

+ favicon.bitmap_data->size(), &icon)) {

NSImage* image = gfx::SkBitmapToNSImage(icon);

if (image) {

// The conversion was successful.