chrome/browser/history/android/android_provider_backend.cc - Issue 10802066: Adds support for saving favicon size into history database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/android_provider_backend.cc

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/android/android_provider_backend.cc

diff --git a/chrome/browser/history/android/android_provider_backend.cc b/chrome/browser/history/android/android_provider_backend.cc

index b2243318fb2db66c6051b9112de6174d7ff93f25..399187474f20ea571fb68859d82e388895f54902 100644

--- a/chrome/browser/history/android/android_provider_backend.cc

+++ b/chrome/browser/history/android/android_provider_backend.cc

@@ -950,7 +950,8 @@ bool AndroidProviderBackend::SimulateUpdateURL(

FaviconID favicon_id = statement->statement()->ColumnInt64(4);

if (favicon_id) {

std::vector<unsigned char> favicon;

- if (!thumbnail_db_->GetFavicon(favicon_id, NULL, &favicon, NULL, NULL))

+ if (!thumbnail_db_->GetFavicon(favicon_id, NULL, &favicon, NULL, NULL,

+ NULL))

return false;

if (!favicon.empty())

new_row.set_favicon(favicon);