components/proximity_auth/webui/BUILD.gn - Issue 1080163002: Add new chrome://proximity-auth WebUI for debugging Smart Lock.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/proximity_auth/webui/BUILD.gn

Issue 1080163002: Add new chrome://proximity-auth WebUI for debugging Smart Lock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # GYP version: components/proximity_auth.gypi:proximity_auth_webui

	6 static_library("webui") {

	7 sources = [

	8 "proximity_auth_ui.cc",

	9 "proximity_auth_ui.h",

	10 "proximity_auth_webui_constants.cc",

	11 "proximity_auth_webui_constants.h",

	12 "proximity_auth_webui_handler.cc",

	13 "proximity_auth_webui_handler.h",

	14 ]

	15

	16 deps = [

	17 "//base",

	18 "//components/proximity_auth",

	19 "//components/proximity_auth/cryptauth",
	Ilya Sherman 2015/04/14 00:25:44 Hmm, why does the webui depend on both of these? Hmm, why does the webui depend on both of these? Tim Song 2015/04/14 06:00:12 I want to also add UI to make CryptAuth calls, lik Show quoted text On 2015/04/14 00:25:44, Ilya Sherman wrote: > Hmm, why does the webui depend on both of these? I want to also add UI to make CryptAuth calls, like GetMyDevices, which is very useful for debugging the server state. Ilya Sherman 2015/04/14 21:47:53 Let's add deps as they become relevant, rather tha Show quoted text On 2015/04/14 06:00:12, Tim Song wrote: > On 2015/04/14 00:25:44, Ilya Sherman wrote: > > Hmm, why does the webui depend on both of these? > > I want to also add UI to make CryptAuth calls, like GetMyDevices, which is very > useful for debugging the server state. Let's add deps as they become relevant, rather than trying to add all the likely candidates upfront. Tim Song 2015/04/14 23:24:05 Done. Show quoted text On 2015/04/14 21:47:53, Ilya Sherman wrote: > On 2015/04/14 06:00:12, Tim Song wrote: > > On 2015/04/14 00:25:44, Ilya Sherman wrote: > > > Hmm, why does the webui depend on both of these? > > > > I want to also add UI to make CryptAuth calls, like GetMyDevices, which is > very > > useful for debugging the server state. > > Let's add deps as they become relevant, rather than trying to add all the likely > candidates upfront. Done.
	20 "//components/resources",

	21 "//content/public/browser",
	Ilya Sherman 2015/04/14 00:25:44 We'll need to create a DEPS file for the webui sub We'll need to create a DEPS file for the webui subdirectory, right? Tim Song 2015/04/14 06:00:12 Sorry, forgot to add the DEPS file. Show quoted text On 2015/04/14 00:25:44, Ilya Sherman wrote: > We'll need to create a DEPS file for the webui subdirectory, right? Sorry, forgot to add the DEPS file.
	22 ]

	23 }

OLD	NEW