Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 1080143003: Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Add delegate accessor from Navigator + Re-add scoped trackers Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc
index 8cdfedfaa3c6d52715b2164eed65138b1b6c88f1..836e3676d519f12e4145ec3a2c5f743459a87c79 100644
--- a/content/browser/web_contents/web_contents_impl_browsertest.cc
+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc
@@ -576,16 +576,15 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,
new LoadProgressDelegateAndObserver(shell()));
RenderFrameHost* main_frame = shell()->web_contents()->GetMainFrame();
FrameHostMsg_DidStartLoading start_msg(main_frame->GetRoutingID(), true);
- static_cast<WebContentsImpl*>(shell()->web_contents())->OnMessageReceived(
- main_frame, start_msg);
+ static_cast<RenderFrameHostImpl*>(main_frame)->OnMessageReceived(start_msg);
EXPECT_TRUE(delegate->did_start_loading);
EXPECT_FALSE(delegate->did_stop_loading);
// Also simulate a DidChangeLoadProgress, but not a DidStopLoading.
FrameHostMsg_DidChangeLoadProgress progress_msg(main_frame->GetRoutingID(),
1.0);
- static_cast<WebContentsImpl*>(shell()->web_contents())->OnMessageReceived(
- main_frame, progress_msg);
+ static_cast<RenderFrameHostImpl*>(main_frame)->OnMessageReceived(
+ progress_msg);
EXPECT_TRUE(delegate->did_start_loading);
EXPECT_FALSE(delegate->did_stop_loading);

Powered by Google App Engine
This is Rietveld 408576698