Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI.

content/browser/frame_host/frame_tree.cc

Index: content/browser/frame_host/frame_tree.cc
diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc
index e7c814e6b49527fae2c15cf64ed019cd2d919f97..df94cd560979108e1c4a5a670e296dacd5de8dbb 100644
--- a/content/browser/frame_host/frame_tree.cc
+++ b/content/browser/frame_host/frame_tree.cc
@@ -52,19 +52,18 @@ bool CollectLoadProgress(double* progress,
                          int* frame_count,
                          FrameTreeNode* node) {
   // Ignore the current frame if it has not started loading.
-  double frame_progress = node->loading_progress();
-  if (frame_progress == FrameTreeNode::kLoadingProgressNotStarted)
+  if (!node->HasStartedLoading())
     return true;
 
   // Collect progress.
-  *progress += frame_progress;
+  *progress += node->loading_progress();
   (*frame_count)++;
   return true;
 }
 
 // Helper function used with FrameTree::ForEach() to reset the load progress.
 bool ResetNodeLoadProgress(FrameTreeNode* node) {
-  node->set_loading_progress(FrameTreeNode::kLoadingProgressNotStarted);
+  node->ResetLoadingProgress();
   return true;
 }
 
@@ -97,7 +96,8 @@ FrameTree::FrameTree(Navigator* navigator,
                               render_widget_delegate,
                               manager_delegate,
                               std::string())),
-      focused_frame_tree_node_id_(-1) {
+      focused_frame_tree_node_id_(-1),
+      load_progress_(0.0) {
 }
 
 FrameTree::~FrameTree() {
@@ -347,18 +347,29 @@ void FrameTree::FrameRemoved(FrameTreeNode* frame) {
     on_frame_removed_.Run(frame->current_frame_host());
 }
 
-double FrameTree::GetLoadProgress() {
+void FrameTree::UpdateLoadProgress() {
   double progress = 0.0;
   int frame_count = 0;
 
   ForEach(base::Bind(&CollectLoadProgress, &progress, &frame_count));
   if (frame_count != 0)
     progress /= frame_count;
-  return progress;
+
+  if (progress <= load_progress_)
+    return;
+  load_progress_ = progress;
+
+  // Notify the WebContents.

[nasko, 2015/04/15 15:39:28]

Simple comments that describe behavior of code that is obvious are not allowed
by the style guide.

[Charlie Reis, 2015/04/15 15:52:23]

Actually, I think this comment is useful.  It's not obvious that this notifies
the WebContents, since it looks like it's telling the Navigator.

+  root_->navigator()->DidChangeLoadProgress();
+}
+
+double FrameTree::GetLoadProgress() {
+  return load_progress_;
 }
 
 void FrameTree::ResetLoadProgress() {
   ForEach(base::Bind(&ResetNodeLoadProgress));
+  load_progress_ = 0.0;
 }
 
 bool FrameTree::IsLoading() {