Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 108013004: Build Autofill component on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_autofill_ipc
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.cc
diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc
index 28d92d4350386db2a54d691ff3e847a830d29a45..48438a87a93bd06e74f92b033320bbfb80ae1b4a 100644
--- a/components/autofill/core/browser/personal_data_manager.cc
+++ b/components/autofill/core/browser/personal_data_manager.cc
@@ -866,9 +866,9 @@ void PersonalDataManager::LoadProfiles() {
pending_profiles_query_ = database_->GetAutofillProfiles(this);
}
-// Win and Linux implementations do nothing. Mac and Android implementations
-// fill in the contents of |auxiliary_profiles_|.
-#if !defined(OS_MACOSX) && !defined(OS_ANDROID)
+// Win, Linux, and iOS implementations do nothing. Mac and Android
+// implementations fill in the contents of |auxiliary_profiles_|.
+#if defined(OS_IOS) || (!defined(OS_MACOSX) && !defined(OS_ANDROID))
Ilya Sherman 2013/12/11 22:50:38 Why are changes to this line needed? Does OS_IOS
blundell 2013/12/12 20:53:54 OS_IOS does indeed cause OS_MACOSX to be defined (
Ilya Sherman 2013/12/12 22:34:52 Ok, good to know! Might be worth adding a comment
blundell 2013/12/12 22:41:29 I don't think that we comment this in general. On
void PersonalDataManager::LoadAuxiliaryProfiles() const {
}
#endif

Powered by Google App Engine
This is Rietveld 408576698