Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 108008: Merge change that allows the API call-as-function handlers on... (Closed)

Created:
11 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Merge change that allows the API call-as-function handlers on non-functions to be called using new to 1.1 branch. Committed: http://code.google.com/p/v8/source/detail?r=1855

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins-ia32.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
11 years, 7 months ago (2009-05-05 09:17:19 UTC) #1
Kasper Lund
LGTM, but you should update the V8 version number.
11 years, 7 months ago (2009-05-05 09:21:08 UTC) #2
Mads Ager (chromium)
11 years, 7 months ago (2009-05-05 09:23:04 UTC) #3
On 2009/05/05 09:21:08, Kasper Lund wrote:
> LGTM, but you should update the V8 version number.

Yes, done.

Powered by Google App Engine
This is Rietveld 408576698