Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 1080073004: PlzNavigate: move ownership of the NavigationRequest to the FrameTreeNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index debf309aba67d4d3918bab66bedd250f7993ac0a..724ed2f576dff8f9178219ac00bfa83fcd9cae71 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -85,11 +85,6 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
void CancelNavigation(FrameTreeNode* frame_tree_node) override;
bool IsWaitingForBeforeUnloadACK(FrameTreeNode* frame_tree_node) override;
- // PlzNavigate
- // Returns the navigation request for a given node. Used in tests.
- NavigationRequest* GetNavigationRequestForNodeForTesting(
- FrameTreeNode* frame_tree_node);
-
private:
// Holds data used to track browser side navigation metrics.
struct NavigationMetricsData;
@@ -139,11 +134,6 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
scoped_ptr<NavigatorImpl::NavigationMetricsData> navigation_data_;
- // PlzNavigate: used to track the various ongoing NavigationRequests in the
- // different FrameTreeNodes, based on the frame_tree_node_id.
- typedef base::ScopedPtrHashMap<int64, NavigationRequest> NavigationRequestMap;
- NavigationRequestMap navigation_request_map_;
-
DISALLOW_COPY_AND_ASSIGN(NavigatorImpl);
};

Powered by Google App Engine
This is Rietveld 408576698