Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1080073002: early return from stream peek (Closed)

Created:
5 years, 8 months ago by caryclark
Modified:
5 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

early return from stream peek Don't assert if resources are missing R=scroggo@google.com BUG=skia:3719 Committed: https://skia.googlesource.com/skia/+/30ac464d4845ef6566c436de9bc3404f097da942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/StreamTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 81 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080073002/1
5 years, 8 months ago (2015-04-13 18:30:39 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 18:30:39 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 18:31:50 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 18:46:27 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 19:01:23 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 19:16:50 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 19:31:15 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 19:46:21 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 20:01:29 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 20:16:21 UTC) #11
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 20:31:21 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 20:46:40 UTC) #13
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 21:01:32 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 21:16:39 UTC) #15
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 21:31:51 UTC) #16
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 21:46:48 UTC) #17
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 22:01:57 UTC) #18
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 22:17:08 UTC) #19
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 22:35:40 UTC) #20
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 22:47:18 UTC) #21
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 23:02:00 UTC) #22
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 23:17:07 UTC) #23
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 23:32:23 UTC) #24
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 23:47:06 UTC) #25
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 00:01:52 UTC) #26
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 00:16:29 UTC) #27
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 00:31:35 UTC) #28
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 00:46:51 UTC) #29
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 01:01:47 UTC) #30
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 01:18:14 UTC) #31
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 01:31:07 UTC) #32
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 01:47:58 UTC) #33
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 02:00:56 UTC) #34
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 02:16:19 UTC) #35
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 02:30:53 UTC) #36
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 02:45:43 UTC) #37
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 03:01:02 UTC) #38
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 03:15:45 UTC) #39
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 03:30:49 UTC) #40
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 03:45:53 UTC) #41
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 04:00:42 UTC) #42
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 04:15:47 UTC) #43
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 04:30:51 UTC) #44
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 04:45:45 UTC) #45
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 05:00:49 UTC) #46
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 05:15:53 UTC) #47
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 05:30:47 UTC) #48
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 05:45:42 UTC) #49
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 06:00:40 UTC) #50
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 06:15:48 UTC) #51
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 06:30:42 UTC) #52
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 06:45:52 UTC) #53
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 07:00:46 UTC) #54
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 07:15:56 UTC) #55
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 07:30:48 UTC) #56
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 07:45:53 UTC) #57
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 08:00:43 UTC) #58
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 08:15:50 UTC) #59
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 08:30:45 UTC) #60
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 08:45:44 UTC) #61
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 09:00:45 UTC) #62
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 09:15:50 UTC) #63
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 09:30:59 UTC) #64
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 09:46:04 UTC) #65
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 10:00:55 UTC) #66
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 10:16:01 UTC) #67
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 10:31:09 UTC) #68
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 10:45:53 UTC) #69
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 11:00:59 UTC) #70
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 11:16:02 UTC) #71
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 11:31:07 UTC) #72
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 11:46:01 UTC) #73
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 12:00:53 UTC) #74
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 12:15:58 UTC) #75
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 12:30:51 UTC) #76
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 12:45:50 UTC) #77
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-14 13:01:21 UTC) #78
reed1
lgtm
5 years, 8 months ago (2015-04-14 13:06:26 UTC) #80
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 13:08:08 UTC) #81
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/30ac464d4845ef6566c436de9bc3404f097da942

Powered by Google App Engine
This is Rietveld 408576698