[turbofan] Clean up cached nodes in JSGraph.

[turbofan] Clean up cached nodes in JSGraph.

R=mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/addb10633c99b2b9b799cfc8cd0b796043adb1c9
Cr-Commit-Position: refs/heads/master@{#27870}

[Michael Starzinger, 2015-04-13 16:01:35]

LGTM.

https://codereview.chromium.org/1080023002/diff/1/src/compiler/js-graph.h
File src/compiler/js-graph.h (right):

https://codereview.chromium.org/1080023002/diff/1/src/compiler/js-graph.h#new...
src/compiler/js-graph.h:34: memset(cached_nodes_, 0, sizeof(cached_nodes_));
remark: Not sure our C++ gurus would approve, but to me it looks good.

https://codereview.chromium.org/1080023002/diff/1/src/compiler/js-graph.h#new...
src/compiler/js-graph.h:145: kNumCachedNodes
nit: Maybe add a comment or some other visual cue indicating that
kNumCachedNodes needs to stay last.

[titzer, 2015-04-13 16:23:52]

On 2015/04/13 16:01:35, Michael Starzinger wrote:
> LGTM.
> 
> https://codereview.chromium.org/1080023002/diff/1/src/compiler/js-graph.h
> File src/compiler/js-graph.h (right):
> 
>
https://codereview.chromium.org/1080023002/diff/1/src/compiler/js-graph.h#new...
> src/compiler/js-graph.h:34: memset(cached_nodes_, 0, sizeof(cached_nodes_));
> remark: Not sure our C++ gurus would approve, but to me it looks good.
> 

Explicit loop now.

>
https://codereview.chromium.org/1080023002/diff/1/src/compiler/js-graph.h#new...
> src/compiler/js-graph.h:145: kNumCachedNodes
> nit: Maybe add a comment or some other visual cue indicating that
> kNumCachedNodes needs to stay last.

Done.

[titzer, 2015-04-13 16:24:00]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-04-13 16:24:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1080023002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-04-13 16:24:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1080023002/20001

[commit-bot: I haz the power, 2015-04-13 16:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 16:37:14]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Sven Panne, 2015-04-14 06:14:40]

svenpanne@chromium.org changed reviewers:
+ svenpanne@chromium.org

[Sven Panne, 2015-04-14 06:14:41]

DBC, couldn't resist. :-D

https://codereview.chromium.org/1080023002/diff/20001/src/compiler/js-graph.h
File src/compiler/js-graph.h (right):

https://codereview.chromium.org/1080023002/diff/20001/src/compiler/js-graph.h...
src/compiler/js-graph.h:34: for (size_t i = 0; i < kNumCachedNodes; i++)
cached_nodes_[i] = nullptr;
Even shorter, more readable and having better chance to be optimized:

   std::fill_n(cached_nodes, kNumCachedNodes, nullptr);

That's almost your beloved memset, but done correctly. ;-)

[titzer, 2015-04-16 07:40:28]

On 2015/04/14 06:14:41, Sven Panne wrote:
> DBC, couldn't resist. :-D
> 
> https://codereview.chromium.org/1080023002/diff/20001/src/compiler/js-graph.h
> File src/compiler/js-graph.h (right):
> 
>
https://codereview.chromium.org/1080023002/diff/20001/src/compiler/js-graph.h...
> src/compiler/js-graph.h:34: for (size_t i = 0; i < kNumCachedNodes; i++)
> cached_nodes_[i] = nullptr;
> Even shorter, more readable and having better chance to be optimized:
> 
>    std::fill_n(cached_nodes, kNumCachedNodes, nullptr);
> 
> That's almost your beloved memset, but done correctly. ;-)

Done.

[titzer, 2015-04-16 07:54:19]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-04-16 07:54:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1080023002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-04-16 07:54:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1080023002/80001

[commit-bot: I haz the power, 2015-04-16 07:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 07:57:28]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/4939)

[titzer, 2015-04-16 08:15:48]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-04-16 08:15:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1080023002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-04-16 08:16:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1080023002/100001

[commit-bot: I haz the power, 2015-04-16 08:41:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-16 08:41:57]

Patchset 6 (id:??) landed as
https://crrev.com/addb10633c99b2b9b799cfc8cd0b796043adb1c9
Cr-Commit-Position: refs/heads/master@{#27870}