Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1080003003: Convert checkbox.css to checkbox_style.html. See http://goo.gl/vIGSCO for more information. (Closed)

Created:
5 years, 8 months ago by Kyle Horimoto
Modified:
5 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert checkbox.css to checkbox_style.html. See http://goo.gl/vIGSCO for more information. BUG=477154 Committed: https://crrev.com/a687f31a786645508622482e9033f497364a43cd Cr-Commit-Position: refs/heads/master@{#325303}

Patch Set 1 #

Total comments: 2

Patch Set 2 : michaelpg comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
D chrome/browser/resources/settings/checkbox/checkbox.css View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/resources/settings/checkbox/checkbox.html View 1 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/resources/settings/checkbox/checkbox_style.html View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Kyle Horimoto
5 years, 8 months ago (2015-04-15 01:51:32 UTC) #2
michaelpg
lgtm https://codereview.chromium.org/1080003003/diff/1/chrome/browser/resources/settings/checkbox/checkbox.html File chrome/browser/resources/settings/checkbox/checkbox.html (right): https://codereview.chromium.org/1080003003/diff/1/chrome/browser/resources/settings/checkbox/checkbox.html#newcode4 chrome/browser/resources/settings/checkbox/checkbox.html:4: <link rel="import" href="chrome://md-settings/checkbox/checkbox_style.html"> nit: can we do href="checkbox_style.html", ...
5 years, 8 months ago (2015-04-15 02:07:37 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/1080003003/diff/1/chrome/browser/resources/settings/checkbox/checkbox.html File chrome/browser/resources/settings/checkbox/checkbox.html (right): https://codereview.chromium.org/1080003003/diff/1/chrome/browser/resources/settings/checkbox/checkbox.html#newcode4 chrome/browser/resources/settings/checkbox/checkbox.html:4: <link rel="import" href="chrome://md-settings/checkbox/checkbox_style.html"> On 2015/04/15 02:07:37, michaelpg wrote: > ...
5 years, 8 months ago (2015-04-15 19:08:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080003003/20001
5 years, 8 months ago (2015-04-15 19:08:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 21:09:48 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:10:49 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a687f31a786645508622482e9033f497364a43cd
Cr-Commit-Position: refs/heads/master@{#325303}

Powered by Google App Engine
This is Rietveld 408576698