Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 1079983002: Introduce SmallTypedArray IDL type and use it for bufferSubData (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: updates Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index f0f9fd0e53dc06a298dd3dbfb816e14e70754779..35d5a9e9145940be1647d2f4820f83afe640e134 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -240,6 +240,7 @@ def argument_context(interface, method, argument, index):
'is_explicit_nullable': idl_type.is_explicit_nullable,
'is_nullable': idl_type.is_nullable,
'is_optional': argument.is_optional,
+ 'is_small_typed_array': idl_type.name == 'SmallTypedArray',
'is_variadic': argument.is_variadic,
'is_variadic_wrapper_type': is_variadic_wrapper_type,
'is_wrapper_type': idl_type.is_wrapper_type,
@@ -274,6 +275,8 @@ def cpp_value(interface, method, number_of_arguments):
idl_type = argument.idl_type
if idl_type.name == 'EventListener':
return argument.name
+ if idl_type.name == 'SmallTypedArray':
+ return '%s.first, %s.second' % (argument.name, argument.name)
if (idl_type.name in ['NodeFilter', 'NodeFilterOrNull',
'XPathNSResolver', 'XPathNSResolverOrNull']):
# FIXME: remove this special case

Powered by Google App Engine
This is Rietveld 408576698