Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1079973007: Don't crash if there is no local main frame on WebView::handleInputEvent (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
kenrb, Rick Byers
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't crash if there is no local main frame on WebView::handleInputEvent I'm pretty sure this indicates a bug in some other part of the event handling/routing code, but we're still sorting out those bits for OOPI. Eventually this should be an assert. BUG=475003 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Note: I'm not /really/ sure how we end up in this state, but it's pretty ...
5 years, 8 months ago (2015-04-23 18:50:35 UTC) #2
Rick Byers
I know the OOPIF input routing stuff is still in a lot of flux, so ...
5 years, 8 months ago (2015-04-23 19:40:05 UTC) #3
kenrb
It certainly indicates a bug for WebViewImpl to be getting input events without local main ...
5 years, 8 months ago (2015-04-23 20:14:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079973007/1
5 years, 8 months ago (2015-04-23 20:17:01 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:20:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194321

Powered by Google App Engine
This is Rietveld 408576698