Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1079953002: Better handling of broken applet codebase (Closed)

Created:
5 years, 8 months ago by Daniel Bratell
Modified:
5 years, 8 months ago
Reviewers:
Mike West, fs
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Better handling of broken applet codebase A broken codebase would result in using an invalid url as base url in the KURL constructor and that never results in anything useful (could even crash). Since HTMLAppletElement is deprecated and badly documented the goal of this patch is mostly to avoid the known badness and not to make HTMLAppletElement perfect. R=fs@opera.com BUG=374110 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A LayoutTests/plugins/applet-codebase-crash.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/plugins/applet-codebase-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Daniel Bratell
Already reviewed in https://codereview.chromium.org/315683002/ but that CL broke CQ (too old) so here is a ...
5 years, 8 months ago (2015-04-13 09:49:16 UTC) #1
Mike West
LGTM.
5 years, 8 months ago (2015-04-13 09:50:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079953002/1
5 years, 8 months ago (2015-04-13 09:50:39 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 12:52:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193633

Powered by Google App Engine
This is Rietveld 408576698