Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1079923003: Put newly allocated buffers at the right end of the buffers list (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Put newly allocated buffers at the right end of the buffers list If a major gc happens between allocation and initialization of the buffer, it might be already in old space. Since we need the list of buffers to be sorted from new to old, we keep track of the last buffer and put old buffers to the end BUG=chromium:476032 R=hpayer@chromium.org,dslomov@chromium.org LOG=n Committed: https://crrev.com/05ed6cb6b922e428d70c15c6d5b97aacde84887c Cr-Commit-Position: refs/heads/master@{#27811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M src/heap/heap.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +11 lines, -6 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/objects-visiting.cc View 5 chunks +12 lines, -7 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +12 lines, -3 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-13 11:37:53 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 8 months ago (2015-04-13 15:40:11 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-14 09:22:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079923003/1
5 years, 8 months ago (2015-04-14 09:24:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 09:26:17 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 09:26:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05ed6cb6b922e428d70c15c6d5b97aacde84887c
Cr-Commit-Position: refs/heads/master@{#27811}

Powered by Google App Engine
This is Rietveld 408576698