Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 1079883002: Revert of device scale factor detection: use gtk-xft-dpi consistently (Closed)

Created:
5 years, 8 months ago by Timothy Loh
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of device scale factor detection: use gtk-xft-dpi consistently (patchset #6 id:100001 of https://codereview.chromium.org/1070433002/) Reason for revert: This patch makes content_shell segfault during startup. Program received signal SIGSEGV, Segmentation fault. 0x00000000049d190a in views::DesktopScreenX11::BuildDisplaysFromXRandRInfo (this=0x35ed099f9200) at ../../ui/views/widget/desktop_aura/desktop_screen_x11.cc:291 291 views::LinuxUI::instance()->GetDeviceScaleFactor(); (gdb) bt #0 0x00000000049d190a in views::DesktopScreenX11::BuildDisplaysFromXRandRInfo (this=0x35ed099f9200) at ../../ui/views/widget/desktop_aura/desktop_screen_x11.cc:291 #1 0x00000000049d096f in views::DesktopScreenX11::DesktopScreenX11 (this=0x35ed099f9200) at ../../ui/views/widget/desktop_aura/desktop_screen_x11.cc:107 #2 0x00000000049d1fab in views::CreateDesktopScreen () at ../../ui/views/widget/desktop_aura/desktop_screen_x11.cc:370 #3 0x0000000000451f28 in content::Shell::PlatformInitialize (default_window_size=...) at ../../content/shell/browser/shell_views.cc:421 #4 0x0000000000440158 in content::Shell::Initialize () at ../../content/shell/browser/shell.cc:146 Original issue's description: > device scale factor detection: use gtk-xft-dpi consistently > > Before this CL, we used either gtk-xft-dpi (UI fonts) or the physical DPI of > a more or less random display. This CL consistently uses gtk-xft-dpi which > is the better alternative: users can directly influence it (by changing the > Xft.dpi X resource, or via their gtkrc). > > See also https://github.com/derat/font-config-info for displaying your > current system settings. > > BUG=473089, 143619 > > Committed: https://crrev.com/06cda64742b45e1eb10bbbb66bca4b4da2efb3c9 > Cr-Commit-Position: refs/heads/master@{#324782} TBR=sadrul@chromium.org,oshima@chromium.org,erg@google.com,erg@chromium.org,stapelberg@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473089, 143619 Committed: https://crrev.com/5d03b6013e39b55de40a6789991f6240a79fd2f4 Cr-Commit-Position: refs/heads/master@{#324810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 5 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Timothy Loh
Created Revert of device scale factor detection: use gtk-xft-dpi consistently
5 years, 8 months ago (2015-04-13 03:00:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079883002/1
5 years, 8 months ago (2015-04-13 03:00:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 03:01:02 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 03:02:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d03b6013e39b55de40a6789991f6240a79fd2f4
Cr-Commit-Position: refs/heads/master@{#324810}

Powered by Google App Engine
This is Rietveld 408576698