Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3435)

Unified Diff: content/shell/browser/webkit_test_controller.cc

Issue 1079843002: DevTools: allow storing devtools preferences on the browser side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/webkit_test_controller.cc
diff --git a/content/shell/browser/webkit_test_controller.cc b/content/shell/browser/webkit_test_controller.cc
index 4c0fd3203844f962387c0df4f3f03119f3378605..b74be9ca34315fb1b95699d8ce41b2284cd419c6 100644
--- a/content/shell/browser/webkit_test_controller.cc
+++ b/content/shell/browser/webkit_test_controller.cc
@@ -583,17 +583,17 @@ void WebKitTestController::OnClearDevToolsLocalStorage() {
StoragePartition* storage_partition =
BrowserContext::GetStoragePartition(browser_context, NULL);
storage_partition->GetDOMStorageContext()->DeleteLocalStorage(
- content::LayoutTestDevToolsFrontend::GetDevToolsPathAsURL("", "")
+ content::LayoutTestDevToolsFrontend::GetDevToolsPathAsURL("")
.GetOrigin());
}
-void WebKitTestController::OnShowDevTools(const std::string& settings,
+void WebKitTestController::OnShowDevTools(const std::string& test_path,
const std::string& frontend_url) {
if (!devtools_frontend_) {
devtools_frontend_ = LayoutTestDevToolsFrontend::Show(
- main_window_->web_contents(), settings, frontend_url);
+ main_window_->web_contents(), test_path, frontend_url);
} else {
- devtools_frontend_->ReuseFrontend(settings, frontend_url);
+ devtools_frontend_->ReuseFrontend(test_path, frontend_url);
}
devtools_frontend_->Activate();
devtools_frontend_->Focus();

Powered by Google App Engine
This is Rietveld 408576698