 Chromium Code Reviews
 Chromium Code Reviews Issue 1079843002:
  DevTools: allow storing devtools preferences on the browser side.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1079843002:
  DevTools: allow storing devtools preferences on the browser side.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/devtools/devtools_ui_bindings.cc | 
| diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc | 
| index 294b9c29a24c45a7d158fd6d12dd8c7a5ef7a1f5..3f751d300730cf1ce7985726b725c00905255aee 100644 | 
| --- a/chrome/browser/devtools/devtools_ui_bindings.cc | 
| +++ b/chrome/browser/devtools/devtools_ui_bindings.cc | 
| @@ -8,6 +8,7 @@ | 
| #include "base/json/json_reader.h" | 
| #include "base/json/json_writer.h" | 
| #include "base/metrics/histogram.h" | 
| +#include "base/prefs/scoped_user_pref_update.h" | 
| #include "base/strings/string_number_conversions.h" | 
| #include "base/strings/string_util.h" | 
| #include "base/strings/stringprintf.h" | 
| @@ -17,6 +18,7 @@ | 
| #include "chrome/browser/devtools/devtools_target_impl.h" | 
| #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" | 
| #include "chrome/browser/infobars/infobar_service.h" | 
| +#include "chrome/browser/prefs/pref_service_syncable.h" | 
| #include "chrome/browser/profiles/profile.h" | 
| #include "chrome/browser/themes/theme_properties.h" | 
| #include "chrome/browser/themes/theme_service.h" | 
| @@ -28,6 +30,7 @@ | 
| #include "chrome/browser/ui/tabs/tab_strip_model.h" | 
| #include "chrome/common/chrome_switches.h" | 
| #include "chrome/common/extensions/chrome_manifest_url_handlers.h" | 
| +#include "chrome/common/pref_names.h" | 
| #include "chrome/common/url_constants.h" | 
| #include "chrome/grit/generated_resources.h" | 
| #include "components/infobars/core/confirm_infobar_delegate.h" | 
| @@ -205,6 +208,8 @@ class DefaultBindingsDelegate : public DevToolsUIBindings::Delegate { | 
| void SetIsDocked(bool is_docked) override {} | 
| void OpenInNewTab(const std::string& url) override; | 
| void SetWhitelistedShortcuts(const std::string& message) override {} | 
| + using DispatchCallback = | 
| 
dgozman
2015/04/13 13:37:48
This one is not used.
 | 
| + DevToolsEmbedderMessageDispatcher::Delegate::DispatchCallback; | 
| void InspectedContentsClosing() override; | 
| void OnLoadCompleted() override {} | 
| @@ -735,6 +740,31 @@ void DevToolsUIBindings::SetDevicesUpdatesEnabled(bool enabled) { | 
| } | 
| } | 
| +void DevToolsUIBindings::GetPreferences(const DispatchCallback& callback) { | 
| + const DictionaryValue* prefs = | 
| + profile_->GetPrefs()->GetDictionary(prefs::kDevToolsPreferences); | 
| + callback.Run(prefs); | 
| +} | 
| + | 
| +void DevToolsUIBindings::SetPreference(const std::string& name, | 
| + const std::string& value) { | 
| + DictionaryPrefUpdate update(profile_->GetPrefs(), | 
| + prefs::kDevToolsPreferences); | 
| + update.Get()->SetStringWithoutPathExpansion(name, value); | 
| +} | 
| + | 
| +void DevToolsUIBindings::RemovePreference(const std::string& name) { | 
| + DictionaryPrefUpdate update(profile_->GetPrefs(), | 
| + prefs::kDevToolsPreferences); | 
| + update.Get()->RemoveWithoutPathExpansion(name, nullptr); | 
| +} | 
| + | 
| +void DevToolsUIBindings::ClearPreferences() { | 
| + DictionaryPrefUpdate update(profile_->GetPrefs(), | 
| + prefs::kDevToolsPreferences); | 
| + update.Get()->Clear(); | 
| +} | 
| + | 
| void DevToolsUIBindings::SendMessageToBrowser(const std::string& message) { | 
| if (agent_host_.get()) | 
| agent_host_->DispatchProtocolMessage(message); |