Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: golden/go/ignore/monitor.go

Issue 1079833002: Add monitoring for expired ignore rules. (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | golden/go/skiacorrectness/main.go » ('j') | golden/go/skiacorrectness/main.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: golden/go/ignore/monitor.go
diff --git a/golden/go/ignore/monitor.go b/golden/go/ignore/monitor.go
new file mode 100644
index 0000000000000000000000000000000000000000..6721a5281f9977c2b7c19bde71cf5f86af8f881f
--- /dev/null
+++ b/golden/go/ignore/monitor.go
@@ -0,0 +1,50 @@
+package ignore
+
+import (
+ "fmt"
+ "time"
+
+ "github.com/rcrowley/go-metrics"
+ "github.com/skia-dev/glog"
+ imetrics "go.skia.org/infra/go/metrics"
+)
+
+func oneStep(store IgnoreStore, metric metrics.Gauge) error {
+ list, err := store.List()
+ if err != nil {
+ return err
+ }
+ n := 0
+ for _, rule := range list {
+ if time.Now().After(rule.Expires) {
+ n += 1
+ }
+ }
+ metric.Update(int64(n))
+ return nil
+}
+
+// StartMonitoring starts a new monitoring routine for the given
+// ignore store that counts expired ignore rules and pushes
+// that info into a metric.
+func StartMonitoring(store IgnoreStore, r metrics.Registry) error {
+ numExpired := metrics.NewRegisteredGauge("num-expired-ignore-rules", r)
+ liveness := imetrics.NewLiveness("expired-ignore-rules-monitoring")
+
+ err := oneStep(store, numExpired)
+ if err != nil {
+ return fmt.Errorf("Unable to start monitoring ignore rules: %s", err)
+ }
+ go func() {
+ for _ = range time.Tick(time.Minute) {
+ err = oneStep(store, numExpired)
+ if err != nil {
+ glog.Errorf("Failed one step of monitoring ignore rules: %s", err)
+ continue
+ }
+ liveness.Update()
+ }
+ }()
+
+ return nil
+}
« no previous file with comments | « no previous file | golden/go/skiacorrectness/main.go » ('j') | golden/go/skiacorrectness/main.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698