Add monitoring for expired ignore rules.

Add monitoring for expired ignore rules.

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/8fb08c6a51f838573e94044e54e5ebf21cb54c62

[jcgregorio, 2015-04-13 12:03:04]

jcgregorio@google.com changed reviewers:
+ stephana@google.com

[stephana, 2015-04-13 13:56:57]

https://codereview.chromium.org/1079833002/diff/20001/golden/go/skiacorrectne...
File golden/go/skiacorrectness/main.go (right):

https://codereview.chromium.org/1079833002/diff/20001/golden/go/skiacorrectne...
golden/go/skiacorrectness/main.go:373: if err :=
ignore.StartMonitoring(storages.IgnoreStore, metrics.DefaultRegistry); err !=
nil {
How about calling this Init and setting the DefaultRegistry in the Init function
? So it would be something like this:

if err := ignore.Init(storages)
... 


It think that pattern is desirable when we are never going to have more than one
instance of a type in an app.

[jcgregorio, 2015-04-13 14:10:59]

https://codereview.chromium.org/1079833002/diff/20001/golden/go/skiacorrectne...
File golden/go/skiacorrectness/main.go (right):

https://codereview.chromium.org/1079833002/diff/20001/golden/go/skiacorrectne...
golden/go/skiacorrectness/main.go:373: if err :=
ignore.StartMonitoring(storages.IgnoreStore, metrics.DefaultRegistry); err !=
nil {
On 2015/04/13 13:56:57, stephana wrote:
> How about calling this Init and setting the DefaultRegistry in the Init
function
> ? So it would be something like this:
> 
> if err := ignore.Init(storages)
> ... 
> 
> 
> It think that pattern is desirable when we are never going to have more than
one
> instance of a type in an app. 

Done.

[stephana, 2015-04-13 17:07:01]

On 2015/04/13 14:10:59, jcgregorio wrote:
>
https://codereview.chromium.org/1079833002/diff/20001/golden/go/skiacorrectne...
> File golden/go/skiacorrectness/main.go (right):
> 
>
https://codereview.chromium.org/1079833002/diff/20001/golden/go/skiacorrectne...
> golden/go/skiacorrectness/main.go:373: if err :=
> ignore.StartMonitoring(storages.IgnoreStore, metrics.DefaultRegistry); err !=
> nil {
> On 2015/04/13 13:56:57, stephana wrote:
> > How about calling this Init and setting the DefaultRegistry in the Init
> function
> > ? So it would be something like this:
> > 
> > if err := ignore.Init(storages)
> > ... 
> > 
> > 
> > It think that pattern is desirable when we are never going to have more than
> one
> > instance of a type in an app. 
> 
> Done.

lgtm

[jcgregorio, 2015-04-13 17:08:09]

The CQ bit was checked by jcgregorio@google.com

[commit-bot: I haz the power, 2015-04-13 17:08:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079833002/40001

[commit-bot: I haz the power, 2015-04-13 17:09:29]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/buildbot/+/8fb08c6a51f838573e94044e54e5ebf21cb5...