Issue 1079813002: use anon namespace to avoid (silent) collisions between local test classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1079813002: use anon namespace to avoid (silent) collisions between local test classes (Closed)

Created:
5 years, 8 months ago by reed2

Modified:
5 years, 8 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

use anon namespace to avoid (silent) collisions between local test classes BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/ffab15f60e784dfb7c29608968dc3030c3f7fc68

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	gm/drawfilter.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	tests/DrawFilterTest.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079813002/1

5 years, 8 months ago (2015-04-12 02:20:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079813002/1

5 years, 8 months ago (2015-04-12 02:29:22 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-12 02:29:34 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ffab15f60e784dfb7c29608968dc3030c3f7fc68