Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

Issue 1079693002: Complete WebStateObserverBridge and follow Cocoa naming style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
diff --git a/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm b/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
index 8f82627b5b5bbff5330b9b73aced068e1911c2a6..97cf16481ae79b8e1c48c9b8ed92070a34bd4e41 100644
--- a/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
+++ b/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
@@ -362,20 +362,20 @@ bool ComputeFramesOfKeyboardParts(UIView* inputAccessoryView,
#pragma mark -
#pragma mark CRWWebStateObserver
-- (void)pageLoaded:(web::WebState*)webState {
+- (void)webStateDidLoadPage:(web::WebState*)webState {
[self reset];
}
-- (void)formActivity:(web::WebState*)webState
- formName:(const std::string&)formName
- fieldName:(const std::string&)fieldName
- type:(const std::string&)type
- value:(const std::string&)value
- keyCode:(int)keyCode
- error:(BOOL)error {
+- (void)webState:(web::WebState*)webState
+ didRegisterFormActivityWithFormNamed:(const std::string&)formName
+ fieldName:(const std::string&)fieldName
+ type:(const std::string&)type
+ value:(const std::string&)value
+ keyCode:(int)keyCode
+ inputMissing:(BOOL)inputMissing {
web::URLVerificationTrustLevel trustLevel;
const GURL pageURL(webState->GetCurrentURL(&trustLevel));
- if (error || trustLevel != web::URLVerificationTrustLevel::kAbsolute ||
+ if (inputMissing || trustLevel != web::URLVerificationTrustLevel::kAbsolute ||
!web::UrlHasWebScheme(pageURL) || !webState->ContentIsHTML()) {
[self reset];
return;

Powered by Google App Engine
This is Rietveld 408576698